marcus/scour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix bug 833666, "scour does not clean comments if file starts with a comment", by correctly and efficiently iterating over the elements of a live sequence. Unit tests are updated.

Browse source
This commit is contained in:
Louis Simard 2012-05-03 15:33:11 -04:00
parent 4b10b6d627
commit 58ddeb855b
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
scour.py
View file

@ -2575,7 +2575,9 @@ def removeComments(element) :
if isinstance(element, xml.dom.minidom.Document):
# must process the document object separately, because its
# documentElement's nodes have None as their parentNode
for subelement in element.childNodes:
# iterate in reverse order to prevent mess-ups with renumbering
for index in xrange(len(element.childNodes) - 1, -1, -1):
subelement = element.childNodes[index]
if isinstance(subelement, xml.dom.minidom.Comment):
numCommentBytes += len(subelement.data)
element.removeChild(subelement)
@ -2585,7 +2587,9 @@ def removeComments(element) :
numCommentBytes += len(element.data)
element.parentNode.removeChild(element)
else:
for subelement in element.childNodes:
# iterate in reverse order to prevent mess-ups with renumbering
for index in xrange(len(element.childNodes) - 1, -1, -1):
subelement = element.childNodes[index]
removeComments(subelement)
def embedRasters(element, options) :