marcus/scour
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

removeDefaultAttributeValue: Special-case order attribute

Browse source 
Scour tried to handle "order" attribute as a SVGLength.  However, the
"order" attribute *can* consist of two integers according to the
[SVG 1.1 Specification] and SVGLength is not designed to handle that.

With this change, we now pretend that "order" is a string, which side
steps this issue.

[SVG 1.1 Specification]: https://www.w3.org/TR/SVG11/single-page.html#filters-feConvolveMatrixElementOrderAttribute

Closes: #189
Signed-off-by: Niels Thykier <niels@thykier.net>
This commit is contained in:
Niels Thykier 2018-04-17 19:05:52 +00:00
parent 8ddb7d8913
commit a459d629c1
3 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

11
unittests/remove-default-attr-order.svg Normal file
View file

@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink= "http://www.w3.org/1999/xlink">
<defs>
<filter id="filter" filterUnits="objectBoundingBox" x="0%" y="0%" width="100%" height="100%">
<feConvolveMatrix order="3 1" kernelMatrix="0.3333 0.3333 0.3333" edgeMode="none"/>
</filter>
</defs>
<!-- Use the filter (otherwise, scour discards it before it trips over it) -->
<image id="png" x="10" y="30" width="150" height="50" xlink:href="raster.png"
filter="url(#filter)"/>
</svg>
Side by side

After

Width:  |  Height:  |  Size: 562 B