From ace24df5c3245a556581839f7cbbd6fe92b214f4 Mon Sep 17 00:00:00 2001 From: Niels Thykier Date: Mon, 18 May 2020 21:00:55 +0000 Subject: [PATCH] removeDuplicateGradients: Avoid compiling regex unless we need it Signed-off-by: Niels Thykier --- scour/scour.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scour/scour.py b/scour/scour.py index 5ba03fd..97ec672 100644 --- a/scour/scour.py +++ b/scour/scour.py @@ -1581,11 +1581,11 @@ def removeDuplicateGradients(doc): # for each element that referenced the gradient we are going to replace dup_id with master_id dup_id = dupGrad.getAttribute('id') - funcIRI = re.compile('url\\([\'"]?#' + dup_id + '[\'"]?\\)') # matches url(#a), url('#a') and url("#a") # With --keep-unreferenced-defs, we can end up with # unreferenced gradients. See GH#156. if dup_id in referencedIDs: + funcIRI = re.compile('url\\([\'"]?#' + dup_id + '[\'"]?\\)') # matches url(#a), url('#a') and url("#a") for elem in referencedIDs[dup_id]: # find out which attribute referenced the duplicate gradient for attr in ['fill', 'stroke']: